diff options
author | Thomas Haller <thaller@redhat.com> | 2023-09-08 16:14:24 +0200 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2023-09-09 16:19:54 +0200 |
commit | 5b29bfee661328e60f7863d1d14b333253f86457 (patch) | |
tree | a42a5431b1ca1a356c8dbcd5424f712ed722696c /examples/nft-json-file.c | |
parent | bd063341a552c5e79cffa26e8b7a06fcdbfcd96c (diff) |
tests/shell: honor .nodump file for tests without nft dumps
For some tests, the dump is not stable or useful to test. For example,
if they have an "expires" timestamps. Those tests don't have a .nft file
in the dumps directory, and don't have it checked.
DUMPGEN=y generates a new dump file, if the "dumps/" directory exists.
Omitting that directory is a way to prevent the generation of the file.
However, many such tests share their directory with tests that do have dumps.
When running tests with DUMPGEN=y, new files for old tests are generated.
Those files are not meant to be compared or committed to git because
it's known to not work.
Whether a test has a dump file, is part of the test. The absence of the
dump file should also be recorded and committed to git.
Add a way to opt-out from such generating such dumps by having .nodump
files instead of the .nft dump.
Later we should add unit tests that checks that no test has both a .nft
and a .nodump file in git, that the .nodump file is always empty, and
that every .nft/.nodump file has a corresponding test committed to git.
Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'examples/nft-json-file.c')
0 files changed, 0 insertions, 0 deletions