diff options
| author | Thomas Haller <thaller@redhat.com> | 2023-07-18 12:33:09 +0200 |
|---|---|---|
| committer | Phil Sutter <phil@nwl.cc> | 2023-07-19 12:42:07 +0200 |
| commit | ae1f506b5b0925dfe07215876f010dd087785ca9 (patch) | |
| tree | 26c17fc45fefb2814dd332361bb72d34075cb4f4 /py | |
| parent | 574fa55c2e70449887c7714d7b043f4e8b6d28da (diff) | |
py: return boolean value from Nftables.__[gs]et_output_flag()
The callers of __get_output_flag() and __set_output_flag(), for example
get_reversedns_output(), are all documented to return a "boolean" value.
Instead, they returned the underlying, non-zero flags value. That number
is not obviously useful to the caller, because there is no API so that
the caller could do anything with it (except evaluating it in a boolean
context). Adjust that, to match the documentation.
The alternative would be to update the documentation, to indicate that
the functions return a non-zero integer when the flag is set. That would
preserve the previous behavior and maybe the number could be useful
somehow(?).
Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'py')
| -rw-r--r-- | py/nftables.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/py/nftables.py b/py/nftables.py index 6daeafc2..68fcd7dd 100644 --- a/py/nftables.py +++ b/py/nftables.py @@ -154,7 +154,7 @@ class Nftables: def __get_output_flag(self, name): flag = self.output_flags[name] - return self.nft_ctx_output_get_flags(self.__ctx) & flag + return (self.nft_ctx_output_get_flags(self.__ctx) & flag) != 0 def __set_output_flag(self, name, val): flag = self.output_flags[name] @@ -164,7 +164,7 @@ class Nftables: else: new_flags = flags & ~flag self.nft_ctx_output_set_flags(self.__ctx, new_flags) - return flags & flag + return (flags & flag) != 0 def get_reversedns_output(self): """Get the current state of reverse DNS output. |