path: root/src/cli.c
diff options
authorPhil Sutter <>2017-10-25 13:40:29 +0200
committerPablo Neira Ayuso <>2017-10-26 20:14:24 +0200
commit94a945ffa81b7f1db250e519f0b4b808428ab223 (patch)
tree869b5960a682e6379762db0cd385b4aec52b6c4b /src/cli.c
parentf8596968a650c66e0b4d5895b700d03d7518b245 (diff)
libnftables: Get rid of explicit cache flushes
In the past, CLI as a potentially long running process had to make sure it kept it's cache up to date with kernel's rule set. A simple test case is this: | shell a | shell b | | # nft -i | # nft add table ip t | | | nft> list ruleset | | table ip t { | | } | # nft flush ruleset | | | nft> list ruleset | | nft> In order to make sure interactive CLI wouldn't incorrectly list the table again in the second 'list' command, it immediately flushed it's cache after every command execution. This patch eliminates the need for that by making cache updates depend on kernel's generation ID: A cache update stores the current rule set's ID in struct nft_cache, consecutive calls to cache_update() compare that stored value to the current generation ID received from kernel - if the stored value is zero (i.e. no previous cache update did happen) or if it doesn't match the kernel's value (i.e. cache is outdated) the cache is flushed and fully initialized again. Signed-off-by: Phil Sutter <> Signed-off-by: Pablo Neira Ayuso <>
Diffstat (limited to 'src/cli.c')
1 files changed, 0 insertions, 1 deletions
diff --git a/src/cli.c b/src/cli.c
index 37351f2f..ec4d2a6f 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -128,7 +128,6 @@ static void cli_complete(char *line)
nft_run_cmd_from_buffer(cli_nft, line, len + 2);
- nft_ctx_flush_cache(cli_nft);
static char **cli_completion(const char *text, int start, int end)