summaryrefslogtreecommitdiffstats
path: root/src/libnftables.c
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2023-07-10 10:45:19 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2023-07-10 18:21:19 +0200
commitcb11cbb01fb638cf5713f5715653c099e7019155 (patch)
treeb82c56ec600afbc554781ed58725f1274c4914c3 /src/libnftables.c
parent0c5c12f410d70c764ed0c333bf638665aca53d1c (diff)
libnftables: drop check for nf_sock in nft_ctx_free()
The "nft_ctx" API does not provide a way to change or reconnect the netlink socket. And none of the users would rely on that. Also note that nft_ctx_new() initializes nf_sock via nft_mnl_socket_open(), which panics of the socket could not be initialized. This means, the check is unnecessary and needlessly confusing. Drop it. Signed-off-by: Thomas Haller <thaller@redhat.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/libnftables.c')
-rw-r--r--src/libnftables.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/libnftables.c b/src/libnftables.c
index 79dfdfc7..6fc4f7db 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -337,8 +337,7 @@ const char *nft_ctx_get_error_buffer(struct nft_ctx *ctx)
EXPORT_SYMBOL(nft_ctx_free);
void nft_ctx_free(struct nft_ctx *ctx)
{
- if (ctx->nf_sock)
- mnl_socket_close(ctx->nf_sock);
+ mnl_socket_close(ctx->nf_sock);
exit_cookie(&ctx->output.output_cookie);
exit_cookie(&ctx->output.error_cookie);