diff options
| author | Thomas Haller <thaller@redhat.com> | 2023-09-08 00:07:16 +0200 |
|---|---|---|
| committer | Florian Westphal <fw@strlen.de> | 2023-09-08 11:50:41 +0200 |
| commit | 92abca4c3b8bde5f862bb3b724c3577a25f742af (patch) | |
| tree | 06d3a9bc87353460e27c916819e29ac4112e2eb0 /tests/shell/run-tests.sh | |
| parent | 0529cc744b08dc4e63be8787c0ba9020e172e738 (diff) | |
tests/shell: fix handling failures with VALGRIND=y
With VALGRIND=y, on memleaks the tests did not fail. Fix that by passing
"--error-exitcode=122" to valgrind.
But just returning 122 from $NFT command may not correctly fail the test.
Instead, ensure to write a "rc-failed-valrind" file, which is picked up
by "test-wrapper.sh" to properly handle the valgrind failure (and fail
with error code 122 itself).
Also, accept NFT_TEST_VALGRIND_OPTS variable to a pass additional
arguments to valgrind. For example a "--suppressions" file.
Also show the special error code [VALGRIND] in "run-test.sh".
Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'tests/shell/run-tests.sh')
| -rwxr-xr-x | tests/shell/run-tests.sh | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh index c8688587..ab91fd4d 100755 --- a/tests/shell/run-tests.sh +++ b/tests/shell/run-tests.sh @@ -527,7 +527,9 @@ print_test_result() { else ((failed++)) result_msg_level="W" - if [ "$rc_got" -eq 123 ] ; then + if [ "$rc_got" -eq 122 ] ; then + result_msg_status="VALGRIND" + elif [ "$rc_got" -eq 123 ] ; then result_msg_status="TAINTED" elif [ "$rc_got" -eq 124 ] ; then result_msg_status="DUMP FAIL" |