diff options
author | Thomas Haller <thaller@redhat.com> | 2023-11-02 09:15:41 +0100 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2023-11-02 09:36:45 +0100 |
commit | 65d94af52f11a2c5a44d5ae8aa3891ccb648c666 (patch) | |
tree | 9979916bca2c9c3c6ba3abb6a4e2a3bd4d1964a4 /tests | |
parent | 4b6a4ad9134fa71277c2ff7f92776e1faeb83000 (diff) |
tests/shell: fix mount command in "test-wrapper.sh"
With Fedora 39 (util-linux-core-2.39.2-1.fc39), the mount command starts
to fail. It was still working with Fedora 38 (util-linux-core-2.38.1-4.fc38).
$ unshare -f -p -m --mount-proc -U --map-root-user -n bash -c 'mount -t tmpfs --make-private /var/run && mount'
mount: /run: mount failed: Invalid argument.
Not sure why this starts to fail. But arguably the command line
arguments were wrong. Fix it, we need a pseudo name for the device.
Fixes: df6f1a3e0803 ("tests/shell: bind mount private /var/run/netns in test container")
Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'tests')
-rwxr-xr-x | tests/shell/helpers/test-wrapper.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/shell/helpers/test-wrapper.sh b/tests/shell/helpers/test-wrapper.sh index 872a0c56..b74c5616 100755 --- a/tests/shell/helpers/test-wrapper.sh +++ b/tests/shell/helpers/test-wrapper.sh @@ -48,7 +48,7 @@ if [ "$NFT_TEST_HAS_UNSHARED_MOUNT" = y ] ; then # Note that this also hides everything that might reside in /var/run. # That is desirable, as tests should not depend on content there (or if # they do, we need to explicitly handle it as appropriate). - if mount -t tmpfs --make-private "/var/run" ; then + if mount -t tmpfs --make-private tmpfs "/var/run" ; then CLEANUP_UMOUNT_VAR_RUN=y fi mkdir -p /var/run/netns |