diff options
| author | Jan Engelhardt <jengelh@medozas.de> | 2010-12-18 02:04:59 +0100 |
|---|---|---|
| committer | Jan Engelhardt <jengelh@medozas.de> | 2011-01-31 03:05:34 +0100 |
| commit | 73866357e4a7a0fdc1b293bf8863fee2bd56da9e (patch) | |
| tree | 1890725e5f327ba14ccf452ff9e5916954d7908f /extensions/libxt_mac.c | |
| parent | bb8be30857edd501e701c2f22db6c59bd6839c87 (diff) | |
iptables: do not print trailing whitespaces
Due to the use of printf("foobar "), iptables emits spaces at the
end-of-line, which looks odd to some users because it causes the
terminal to wrap even if there is seemingly nothing to print.
It may also have other points of annoyance, such as mailers
interpreting a trailing space as an indicator that the paragraph
continues when format=flowed is also on.
And git highlights trailing spaces in red, so let's avoid :)
Preexisting inconsistencies in outputting spaces in the right
spot are also addressed right away.
References: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=429579
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'extensions/libxt_mac.c')
| -rw-r--r-- | extensions/libxt_mac.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/extensions/libxt_mac.c b/extensions/libxt_mac.c index 15a7f3c1..d7e65dac 100644 --- a/extensions/libxt_mac.c +++ b/extensions/libxt_mac.c @@ -73,10 +73,9 @@ static void print_mac(const unsigned char macaddress[ETH_ALEN]) { unsigned int i; - printf("%02X", macaddress[0]); + printf(" %02X", macaddress[0]); for (i = 1; i < ETH_ALEN; i++) printf(":%02X", macaddress[i]); - printf(" "); } static void mac_check(unsigned int flags) @@ -90,10 +89,10 @@ static void mac_print(const void *ip, const struct xt_entry_match *match, int numeric) { const struct xt_mac_info *info = (void *)match->data; - printf("MAC "); + printf(" MAC"); if (info->invert) - printf("! "); + printf(" !"); print_mac(info->srcaddr); } @@ -103,9 +102,9 @@ static void mac_save(const void *ip, const struct xt_entry_match *match) const struct xt_mac_info *info = (void *)match->data; if (info->invert) - printf("! "); + printf(" !"); - printf("--mac-source "); + printf(" --mac-source"); print_mac(info->srcaddr); } |