summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2023-08-30 13:12:36 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2023-08-31 16:38:14 +0200
commit407bf4ebb52665fd48ecc163baa1f139e609905a (patch)
tree8be64f516d8c6c917e480602da2c7c1b439d25e6
parent1fd8524ffd991d949ff77a9fd5e1b088cb942ed1 (diff)
src: remove check for NULL before calling expr_free()
expr_free() already handles NULL pointer, remove redundant check. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--src/netlink_delinearize.c3
-rw-r--r--src/rule.c4
2 files changed, 3 insertions, 4 deletions
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index 1121f730..bde783bd 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -83,8 +83,7 @@ static void netlink_set_register(struct netlink_parse_ctx *ctx,
return;
}
- if (ctx->registers[reg] != NULL)
- expr_free(ctx->registers[reg]);
+ expr_free(ctx->registers[reg]);
ctx->registers[reg] = expr;
}
diff --git a/src/rule.c b/src/rule.c
index 07b95a99..35f6d8f2 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -193,8 +193,8 @@ void set_free(struct set *set)
if (--set->refcnt > 0)
return;
- if (set->init != NULL)
- expr_free(set->init);
+
+ expr_free(set->init);
if (set->comment)
xfree(set->comment);
handle_free(&set->handle);