diff options
author | Florian Westphal <fw@strlen.de> | 2019-01-04 15:57:00 +0100 |
---|---|---|
committer | Florian Westphal <fw@strlen.de> | 2019-01-04 16:00:31 +0100 |
commit | 4d26b6dd3c4c8354a88c4a1aef8ea33229f0a4cc (patch) | |
tree | 1e82c9b480038033c65cd7d17b08f24e149bcd82 /tests/shell/testcases/chains/0018check_jump_loop_1 | |
parent | eb49882deb3e9ec5eccd6e6106b454e3a6394408 (diff) |
tests: shell: change all test scripts to return 0
The shell-based tests currently encode a return value in the
file name, i.e. foo_1 expects that the script should return '1'
for the test case to pass.
This is very error prone, and one test case is even broken (i.e.,
it returns 1, but because of a different, earlier error).
do_something || exit 1
or
'set -e'
are both pretty common patterns, in both cases tests should fail.
In those test-cases that deliberately test for an error,
nft something_should_fail || exit 0
nft something_should_fail && exit 1
or a similar constructs should be used.
This initial commit modififies all '_1' scripts to return 0 on
success, usually via 'nft wrong || exit 0'.
All tests pass, except the one broken test case that hasn't worked
before either, but where 'set -e' use made it pass (the failing command
is supposed to work, and the command that is supposed to fail is never
run).
Signed-off-by: Florian Westphal <fw@strlen.de>
Diffstat (limited to 'tests/shell/testcases/chains/0018check_jump_loop_1')
-rwxr-xr-x | tests/shell/testcases/chains/0018check_jump_loop_1 | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tests/shell/testcases/chains/0018check_jump_loop_1 b/tests/shell/testcases/chains/0018check_jump_loop_1 index d1443dab..b87520f2 100755 --- a/tests/shell/testcases/chains/0018check_jump_loop_1 +++ b/tests/shell/testcases/chains/0018check_jump_loop_1 @@ -6,5 +6,8 @@ $NFT add table ip filter $NFT add chain ip filter ap1 $NFT add chain ip filter ap2 $NFT add rule ip filter ap1 jump ap2 + # kernel should return EOPNOTSUPP -$NFT add rule ip filter ap1 jump ap1 2>/dev/null >&2 +$NFT add rule ip filter ap1 jump ap1 2>/dev/null >&2 || exit 0 +echo "E: Accepted jump-to-self" +exit 1 |