path: root/include/xtables.h
diff options
authorFlorian Westphal <>2018-11-12 14:40:41 +0100
committerFlorian Westphal <>2018-11-12 18:33:03 +0100
commit61d6c3834de32c0ff5808c93da94b2b30b4791c8 (patch)
tree9286c86102bc3692e6ac30d561fd407de76c257f /include/xtables.h
parent5edb249b25da2d27bca886eb1aa03e6ce65cc8ca (diff)
xtables: add 'printf' attribute to xlate_add
This allows gcc to check format string vs. passed arguments. Fix the fallout from this as well, typical warning produced is: libebt_mark_m.c:112:28: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=] xt_xlate_add(xl, "and 0x%x %s0 ", info->mask, ... ~^ ~~~~~~~~~~ so add the required casts or fixup format strings as needed. libxt_conntrack also passed an unneeded argument (port), so remove that. Signed-off-by: Florian Westphal <>
Diffstat (limited to 'include/xtables.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/include/xtables.h b/include/xtables.h
index 2bc190cd..4aa084a1 100644
--- a/include/xtables.h
+++ b/include/xtables.h
@@ -627,7 +627,7 @@ extern const char *xtables_lmap_id2name(const struct xtables_lmap *, int);
/* xlate infrastructure */
struct xt_xlate *xt_xlate_alloc(int size);
void xt_xlate_free(struct xt_xlate *xl);
-void xt_xlate_add(struct xt_xlate *xl, const char *fmt, ...);
+void xt_xlate_add(struct xt_xlate *xl, const char *fmt, ...) __attribute__((format(printf,2,3)));
void xt_xlate_add_comment(struct xt_xlate *xl, const char *comment);
const char *xt_xlate_get_comment(struct xt_xlate *xl);
const char *xt_xlate_get(struct xt_xlate *xl);